fix(piper): decouple connect enable from calibrate flag

这个提交包含在:
Elvin
2026-03-06 01:35:05 +08:00
父节点 271518d52f
当前提交 ae8efef693
共有 2 个文件被更改,包括 25 次插入 和 3 次删除

查看文件

@ -102,9 +102,9 @@ class PiperFollower(Robot):
if should_auto_calibrate:
logger.info("No piper-follower calibration file found for '%s'. Running lerobot-calibrate flow.", self.id)
self.calibrate()
# lerobot-calibrate calls connect(calibrate=False) before running calibrate().
# Keep the arm in drag mode for that path, but re-enable after connect-time calibration.
should_enable = self.config.enable_on_connect and calibrate
# Enable behavior should be controlled by enable_on_connect, independent from calibrate flag.
# This keeps connect(calibrate=False) commandable for callers that only want to skip interactive calibration.
should_enable = self.config.enable_on_connect
if should_enable and not self._wait_enable(self.config.enable_timeout_s):
logger.warning("Piper follower did not report enabled state before timeout.")

查看文件

@ -318,3 +318,25 @@ def test_piper_follower_connect_calibrates_then_reenables(monkeypatch, tmp_path)
assert robot.arm.is_enabled
finally:
robot.disconnect()
def test_piper_follower_connect_without_calibration_still_enables(monkeypatch, tmp_path):
patch_fake_sdk(monkeypatch)
robot = PiperFollower(
PiperFollowerConfig(
port="can0",
id="connect_enable_without_calibration",
calibration_dir=tmp_path,
calibration_mode="required",
enable_on_connect=True,
)
)
robot.connect(calibrate=False)
try:
assert robot.arm.enable_calls == 1
assert robot.arm.is_enabled
assert robot.arm.disable_calls == 0
finally:
robot.disconnect()